search

penberg / hornet

Hornet, a JVM optimized for low-latency applications.
Other
53 stars 5 forks source link

try to implement getstatic and putstatic #31

Closed jxwr closed 10 years ago

jxwr commented 10 years ago

hi penberg, Could you please review this patch, I'm trying to implement getstatic and putstatic but not sure if it is correct.

penberg commented 10 years ago

@jxwr Looks good to me!

Can you please look at the few minor comments I had about the change and rebase this pull request?

jxwr commented 10 years ago

I fixed the indent and moved static test into a new file. Should I use a branch to send pull request? it seems that new commit will show here auto automatically.

penberg commented 10 years ago

@jxwr No need for a new pull request. Github is able to see new commits and even if you rebase and force push with "git push -f".

penberg commented 10 years ago

I squashed the commits and cleaned up some diff noise. Sorry for being so pendatic. :wink: Thanks for the pull request!

If you are interested in implementing this for the LLVM, there's an incomplete backend in Jato that does support getstatic and putstatic:

https://github.com/jatovm/jato/blob/master/jit/llvm/core.c