Closed pereman2 closed 1 month ago
hmmm why is test failing?
> select * from users, products limit 1;
1|Jamie|Foster|dylan00@example.com|496-522-9493|62375 Johnson Rest Suite 322|West Lauriestad|IL|35865|94|1|hat|79.0
test:
SQLITE_EXEC=./target/debug/limbo ./testing/all.test
Running test: select-const-1
Running test: select-const-2
Running test: select-avg
Running test: select-sum
Running test: select-limit
Running test: select-count
Running test: select-max
Running test: select-min
Running test: select-limit-0
Running test: pragma-cache-size
Running test: cross-join
Test FAILED: 'select * from users, products limit 1;'
returned '1|Jamie|Foster|dylan00@example.com|496-522-9493|62375 Johnson Rest Suite [322](https://github.com/penberg/limbo/actions/runs/9880223932/job/27288743610?pr=115#step:3:323)|West Lauriestad|IL|35865|94|1|hat|79'
expected '1|Jamie|Foster|dylan00@example.com|496-522-9493|62375 Johnson Rest Suite 322|West Lauriestad|IL|35865|94|1|hat|79.0'
make: *** [Makefile:42: test] Error 1
local:
fedora :: ~/fun/limbo » SQLITE_EXEC=./target/debug/limbo ./testing/all.test
Running test: select-const-1
Running test: select-const-2
Running test: select-avg
Running test: select-sum
Running test: select-limit
Running test: select-count
Running test: select-max
Running test: select-min
Running test: select-limit-0
Running test: pragma-cache-size
Running test: cross-join
Running test: cross-join-specific-columns
Running test: realify
nevermind, it was missing a commit from cli/main.rs
Values in sqlite3, as expected, can be stored in different formats to optimize disk usage. In this case, a 79.0 float will be transformed to a u8.
sqlite3 deals with this by adding a RealAffinity op after each column that might need it. Therefore, in this pr we do exactly that :).
sqlite3 explain
limbo explain
Fixes #114