Closed jussisaurio closed 1 month ago
Looks reasonable to me @jussisaurio, but let's give @pereman2 the opportunity to review this too since it's a major improvement just to make sure it's aligned on the overall direction.
Looks reasonable to me @jussisaurio, but let's give @pereman2 the opportunity to review this too since it's a major improvement just to make sure it's aligned on the overall direction.
👍 Sure, it's good to ensure that this can be extended/refactored fairly easily and doesn't paint us into a corner or anything
select foo_col, bar_col from foo join bar on foo_col = bar_col
)select foo.col, bar.col from foo join bar on foo.col = bar.col
)select f.col, b.col from foo f join bar b on f.col = b.col
)select f1.col, f2.col from foo f1 join foo f2 on f1.col = f2.col + 1
)AND
etc, multiple joinsJOIN ... JOIN
,LEFT JOIN
etc(table_identifier: String, table: Table)
; allows duplicates -- raises an error ifresolve_ident_table
is ambiguouswhere
andjoin
Insn::Add
GOTO
instruction fromtranslate_expr
binary expression cases (e.g.select col1 > col2 from table
)Code generation e.g.
Limbo
Sqlite