penberg / limbo

Limbo is a work-in-progress, in-process OLTP database management system, compatible with SQLite.
MIT License
909 stars 50 forks source link

Switch to `lemon-rs` for parsing? #163

Closed penberg closed 1 month ago

penberg commented 1 month ago

The sqlite3-parser crate we use for SQL parsing is surprisingly slow. Let's look into using lemon-rs like libSQL does, which may be faster.

adiSuper94 commented 1 month ago

Hi @penberg I'd like to take a crack at this.

penberg commented 1 month ago

Let's wait to see what happens with https://github.com/gwenn/lemon-rs/pull/57 first. If it's merged, this issue is essentially resolved.

pereman2 commented 1 month ago

sqlite3-parser == lemon-rs right?

penberg commented 1 month ago

I think lemon-rs has a lower level API than the one we use, but can be wrong too

pereman2 commented 1 month ago

https://crates.io/crates/sqlite3-parser look at repo

penberg commented 1 month ago

Obsoleted by https://github.com/penberg/limbo/issues/185