search

penberg / limbo

Limbo is a work-in-progress, in-process OLTP database management system, compatible with SQLite.
MIT License
960 stars 53 forks source link

add `unicode` scalar function #224

Closed ethanniser closed 1 month ago

ethanniser commented 1 month ago

rewrite of #173

the emoji integration test doesnt pass but the unit test does I cant figure out why

penberg commented 1 month ago

The emoji issue may be a parser issue where it turns UTF-8 into ASCII, for example.

ethanniser commented 1 month ago

@penberg the issue is with the testing framework somehow because running the tests with sqlite3 has the same issue and running SELECT unicode('😊'); in the limbo shell works as expected as well

penberg commented 1 month ago

@ethanniser I don't see any issue with the test framework either, I just think that the test you wrote for unicode('') is incorrect.

ethanniser commented 1 month ago

its definitely the tests

image

image

image
penberg commented 1 month ago

@ethanniser Can you please fold all the commits into one to clean up git history a bit and press the "ready for review" button so we can get this thing merged?

ethanniser commented 1 month ago

sure, but there is still this outstanding test issue

im happy to just delete the one that doesnt pass if you really want to merge

ethanniser commented 1 month ago

wait all the tests pass ci??

ethanniser commented 1 month ago

must be a local issue for me then very strange I think this should be good to merge if it looks good to you

thanks again for the help