Closed ethanniser closed 1 month ago
The emoji issue may be a parser issue where it turns UTF-8 into ASCII, for example.
@penberg the issue is with the testing framework somehow because running the tests with sqlite3
has the same issue and running SELECT unicode('😊');
in the limbo shell works as expected as well
@ethanniser I don't see any issue with the test framework either, I just think that the test you wrote for unicode('')
is incorrect.
its definitely the tests
@ethanniser Can you please fold all the commits into one to clean up git history a bit and press the "ready for review" button so we can get this thing merged?
sure, but there is still this outstanding test issue
im happy to just delete the one that doesnt pass if you really want to merge
wait all the tests pass ci??
must be a local issue for me then very strange I think this should be good to merge if it looks good to you
thanks again for the help
rewrite of #173
the emoji integration test doesnt pass but the unit test does I cant figure out why