Closed ethanniser closed 1 month ago
The tests are already run against a pinned version of sqlite in CI:
https://github.com/penberg/limbo/blob/main/.github/workflows/rust.yml#L55-L68
However not against adding a new makefile command to do this locally. Was that the intention?
Didn't realize it was in ci
But yes, I think it's still quite helpful when writing the tests locally
BTW @ethanniser if you're wondering about the string_agg
error in CI, it's because the test runner has a default sqlite3
in PATH
whose version doesn't support string_agg
yet. The github actions YAML file has a comment about that.
@ethanniser I did https://github.com/penberg/limbo/pull/226 but I guess it kind of overlaps with this pull request. So please just tweak the Github config to run the right make target that does not build Limbo.
actually on second thought I think its fine how it is- seems fine to catch it in ci and im not too sure how to specify the version available in the make file
you can just merge #226 and I will close this unless you think this is strongly worth adding
I merged https://github.com/penberg/limbo/pull/226, which kind of obsoletes this. I am totally fine with adding a test-sqlite
and test-limbo
makefile targets, which use EXEC_SQLITE
and EXEC_LIMBO
, respectively, if someone feels like doing that to simplify the local development flow. However, I am closing this PR for now
we might want to check the
sqlite3
version as well