Unicode test failure on macOS

penberg / limbo

Limbo is a work-in-progress, in-process OLTP database management system, compatible with SQLite.

MIT License

960 stars 53 forks source link

Closed penberg closed 1 month ago

penberg commented 1 month ago

The test passes on Linux in the CI, but fails on my macOS at least:

Test FAILED: 'SELECT unicode('ð');'
returned '240'
expected '128522'

jussisaurio commented 1 month ago

Yeah noticed the same, I don't know why I ignored it, thought it was something related to my local setup or something

benclmnt commented 1 month ago

I tried running it interactively

limbo> SELECT unicode('😊');
128522

which is expected, but if I run make test, it fails

penberg commented 1 month ago

This is a TCL 8.5 issue, which is shipped by default on macOS. Upgrading to TCL 8.6 fixes the problem.

Anyone hitting this, just do the following:


brew install tcl-tk
echo 'export PATH="/usr/local/opt/tcl-tk/bin:$PATH"' >> ~/.zshrc
source ~/.zshrc
``