NextAwait's next instruction doesn't match that of SQLite

penberg / limbo

Limbo is a work-in-progress, in-process OLTP database management system, compatible with SQLite.

MIT License

966 stars 58 forks source link

NextAwait's next instruction doesn't match that of SQLite #351

Open arpit-saxena opened 2 days ago

arpit-saxena commented 2 days ago

In the above side-by-side comparison of the same database run in Limbo on the LHS and SQLite3 on the RHS, note that NextAsync's next command is RewindAwait. For SQLite, Next's next command is Column which makes sense that we do that when there are rows left.

I'll try and fix this. Let me know if this is expected for some reason

jussisaurio commented 1 day ago

Yeah I've noticed that, pretty sure it's not expected, go ahead and fix

jussisaurio commented 1 day ago

@arpit-saxena when you do this can you rename ´rewind_labels´ to something else (i think thats how the next backward jumps are called in the code atm)