search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.47k stars 273 forks source link

Cursor icon gets locked when zooming with a stylus #1198

Closed Jose-Moreno closed 3 years ago

Jose-Moreno commented 5 years ago

Issue Summary

After invoking the Navigation tools using modifier keys when using any drawing tool the HAND tool icon gets locked and won't be removed even when drawing.

Workaround: The icon can only be reset by changing selecting the active tool either by pressing the keyboard shortcut or clicking on the toolbar icon.

This was tested with all the cursor options turned OFF, that is having only the "default" crosshair cursor. It happens when the "Tool cursors" option is turned ON as well.

It seems to only happen with a stylus / tablet. It doesn't occur with mouse input. It also happens only when zooming in / out, not with panning the canvas nor tilting.

Expected Results

Despite this bug being non-critical, the icons should never lock when invoking the navigation tools via modifiers or otherwise.

Steps to reproduce

  1. Select a drawing tool
  2. Press CTRL + Click & Drag to zoom in/out using the RMB only (MMB is buggy but doesn't cause this behavior for me, but you're welcome to test either way)
  3. Notice the Hand cursor is locked and replaced the current tool / crosshair cursor.
  4. Try drawing and notice that the icon is still locked.
  5. Select a the same tool via shortcut or toolbox, the icon resets.

System Information

Version: 0.6.3 Operating System: Windows 7 SP 1 (6.1) CPU Architecture: x86_64>

Jose-Moreno commented 3 years ago

This no longer happens for me with version 0.6.5 working under Windows 10. Can anyone else confirm this issue under Windows 7 or other legacy OS? also please test on newer OS as well. I'll keep this open for a few days, and if there's no reply we'll assume it was fixed by https://github.com/scribblemaniac/pencil/commit/36ff1c288da0486c8c25a4db801e0d2163ed6167 and I'll close this.

Jose-Moreno commented 3 years ago

After testing with scribblemaniac, it seems the cursor gets soft-locked even with a mouse but with a more obscure combination of steps:

  1. select a drawing tool
  2. Press & hold the CTRL key in your keyboard. Then Press & hold the Middle Mouse button (MMB) and drag the screen to zoom.
  3. While dragging the mouse immediately switch to press the right mouse button (RMB)
  4. Release the CTRL key first and lastly release the RMB
  5. The cursor has been soft-locked as the hand tool. Drawing will not change it but pressing the ALT key or actively switching tools will change the cursor.