Keyboard shortcut conflict

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.

http://pencil2d.org

GNU General Public License v2.0

1.45k stars 272 forks source link

Keyboard shortcut conflict #1228

Closed setanarut closed 8 months ago

setanarut commented 5 years ago

Issue Summary

"Move Frame Backward" and "Preferences" have the same shortcut as Default

Actual Results

"Preferences" doesn't open by default when I press the shortcut ⌘, "Move Frame Backward" is activated.

Expected Results

"Preferences" must be default when i press ⌘,

### Video or Image Reference ![aa](https://user-images.githubusercontent.com/36481442/59887349-b1137f80-93cb-11e9-9667-35fee8a35ce9.jpg) ### Steps to reproduce ### System Information + Pencil2D Version: Version: 0.6.4 + Operating System: macOS Mojave (10.14) CPU Architecture: x86_64 + RAM Size: 8GB

Jose-Moreno commented 5 years ago

@hazar-e Hi. By default Preferences does not have assigned any keyboard shortcut. However please let us know if it did come like that for your mac version download so one of our mac devs can review if there is a conflict in the source code.

Other than that you can change the hotkey by going to Pencil2D Menu > Preferences > Shortcuts > Preferences and change the hotkey to something more appropriate.

setanarut commented 5 years ago

hi @Jose-Moreno

⌘, shortcut is the standard "Preferences" shortcut for All Apps on MacOS MoveFrameBackward should be different shortcut by default.

scribblemaniac commented 5 years ago

I can confirm this issue, the preferences shortcut is always command+',' on mac and Qt sets this automatically so there is likely very little we can do to remove it (maybe there is some OS-specific hack). I remember having the same issue a long while ago. The obvious workaround is to simply change the MoveFrameBackwards key to something else. Changing the Preferences shortcut will not change it to something else. Personally I use [ and ] for GotoNextFrame and GotoPreviousFrame respectively, and then command+[ and command+] for the corresponding move frame actions. I would be in favor of changing it, but we'll see what the other devs think.

MrStevns commented 5 years ago

If Qt sets the preferences shortcut by default and we can't change it, then we should consider removing the key in shortcuts, or call it something different like "alt to preferences" for alternative shortcut to access preferences.

As for the goto next and previous keys, what @scribblemaniac suggested is fine with me.