search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.47k stars 273 forks source link

macOS dark mode not detected automatically #1229

Closed setanarut closed 3 years ago

setanarut commented 5 years ago

Issue Summary

  1. Pencil2D does not automatically detect macOS dark mode. requires terminal command to be activated. defaults write org.pencil2d.Pencil2D NSRequiresAquaSystemAppearance 0

  2. Background Color, Timeline colors and About window are not compatible with dark mode.

### Video or Image Reference About window ![Jun-21-2019 02-32-37](https://user-images.githubusercontent.com/36481442/59888888-69dcbd00-93d2-11e9-90b5-c33ceefd723b.gif) Timeline and Background color Ekran Resmi 2019-06-21 02 33 48 ### System Information Pencil2D Version: 0.6.4 Operating System: macOS Mojave (10.14) CPU Architecture: x86_64
scribblemaniac commented 5 years ago

Dark mode should be detected automatically on macOS Mojave and newer. Let's focus only on that issue here. The other issues are not mac-specific and have already been discussed in #550.

Pencil2D does not set the NSRequiresAquaSystemAppearance property, so it should follow whatever the default is on your system. Can you please share the output of this command:

defaults read NSRequiresAquaSystemAppearance
MrStevns commented 5 years ago

Qt is still not fully dark mode compatible, I've already reported one issue to the Qt team about this. https://bugreports.qt.io/browse/QTBUG-72486

We can workaround the issue by manually styling the widgets for now. The timeline is all custom drawing, so it is not affected by Mac OS appearance specifics but as Scribblemaniac has stated, that one is already a heavily discussed subject.

setanarut commented 5 years ago

ok sorry. i am using dark mode always, i am big fan of dark mode. you can close this known issue.

you can dark mode ui on all platforms like krita. dark mode should be default theme on all platforms.

MrStevns commented 5 years ago

So are we but there are things of higher priority to be made first :) We'll keep the issue open until the issues has been fixed.

J5lx commented 3 years ago

What exactly is needed for this issue to move forward? A reply about the dark mode detection problem? Bug fixes in Qt’s dark mode support? The about dialog as well as the timeline have already been fixed a while ago.