search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.47k stars 273 forks source link

"About" menu item shows zoom menu in macOS #1398

Open davidlamhauge opened 4 years ago

davidlamhauge commented 4 years ago

Issue Summary

I'm on holiday, and accidentally stumbled upon this: When I press Pencil2D->About , it shows the zoom menu form 25% to 400%, in stead of the dialog.

billede

I'm running an updated master branch, and it's the same whether it is compiled in Debug or Release mode. Can others confirm this behavior, and what about Windows and Linux? As said, I'm on holiday, I only have my MacBook with me and I don't have too much time.

J5lx commented 4 years ago

I’m not seeing this on Linux.

Jose-Moreno commented 4 years ago

Just compiled the latest master. I have the correct menu display the zoom list, and the about action works as intended, so I assume it's only happening on macOS where the specific "apple menu" bridge code occurs.

image

davidlamhauge commented 4 years ago

I've just deleted my build folders and recompiled it, and the bug still occurs. I don't know the apple menu bridge code, but since it has got a 'bug' label, it's can't be my settings that are wrong.

chchwy commented 4 years ago

Qt does some special tricks for the menus on Mac. I fixed a bug of Preference menu item previously. Will check later.

MrStevns commented 4 years ago

Hmm... I can't reproduce this on Mac OS Mojave 10.14.5 compiled with Qt 5.12.3, menu looks and works as expected.

davidlamhauge commented 4 years ago

I have mac OS High Sierra 10.13.6, and compiled it with Qt 5.14.2. I also have 5.12.2 on my machine, but the result is the same. I deleted my compile folder, and recompiled from scratch but the About shows the zoom levels as shown above. Could it be settings on my macBook that causes the problem?

Jose-Moreno commented 4 years ago

Candyface mentioned on discord the following:

Hmm I started noticing that weird bug that David mentioned with the about menu item becoming a sub menu with zoom levels... I found out it happens when the language is set to danish.. not sure if it happens with other languages.

So i'm removing the "investigate" label and treating this as a confirmed issue.