search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.47k stars 273 forks source link

Overlays offset incorrectly displayed with camera layer selected #1685

Closed Jose-Moreno closed 2 years ago

Jose-Moreno commented 2 years ago

Issue Summary

This is an issue that has appeared in the recent builds. Basically the camera overlays are offset when selecting the camera layer regardless of zoom factor.

I previously reported it on discord but I'm putting it here so we can link it to a certain camera fix that @MrStevns was working on. However at the moment I'm not entirely sure if it's the same PR as #1587 Can anyone confirm?

Expected Results

Overlay positioning should remain consistent between selected layer "modes". Camera overlays should display over the camera frame and follow the camera regardless of any applied transform.

Video or Image Reference

Camera Overlays (Bitmap Layer selected) image

Camera Overlays (Camera Layer selected) image

Steps to reproduce

  1. Open Pencil2D
  2. Enable the Display panel (if hidden)
  3. Turn on all the camera overlays
  4. Take note of screen position
  5. Select camera layer
  6. Notice the huge offset (In my test case overlays have shrunk and positioned on the bottom right corner of the camera frame)

System Information

commit: 91b1721baef012d49cffd0d23358524a420af9fd date: 2021-11-14_16:46:59

Operating System: Windows 10 Version 2009 CPU Architecture: x86_64 Qt Version: 5.15.2

MrStevns commented 2 years ago

I previously reported it on discord but I'm putting it here so we can link it to a certain camera fix that @MrStevns was working on. However at the moment I'm not entirely sure if it's the same PR as https://github.com/pencil2d/pencil/pull/1587 Can anyone confirm?

Confirmed, this issue will be fixed via #1587