pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.47k stars 273 forks source link

Make an installer #1762

Closed Juliasmatius closed 8 months ago

Juliasmatius commented 1 year ago

Not really an issue but you don't have any other feedback method.

It always irritates when there is no installer.

Iexpress is free and comes with windows. Usage

Installforge is free even for commercial and non-commercial and offers a better UI than Iexpress

If you are using Linux, you probably can figure it out by yourself.

MrStevns commented 1 year ago

Hi Juliasmatius

We started working on an installer #848 for Windows a long time ago, it just hasn't been finished yet. Given that we are all volunteers, there's no say when or if it'll happen.

We appreciate your feedback nonetheless 😄

Juliasmatius commented 1 year ago

We started working on an installer #848 for Windows a long time ago, it just hasn't been finished yet. Given that we are all volunteers, there's no say when or if it'll happen.

Not to be a jackass but I can probably take 15 minutes this evening and make an installer up to your standards.

scribblemaniac commented 1 year ago

If you don't want to be a jackass, then don't ask other people to do work for you and then tell them how easy it would be for you to do it. We're an open source project run by a very small team of volunteers. If you want to make an installer then you are fully welcome to make an installer and make a pull request for any work you do. I believe we are all interested in having a Windows installer. As previously mentioned one of our core development team has already put in a significant amount of work towards this goal. You are welcome to build upon that or start your own thing from scratch.

To make an installer up to our standards, it should at meet all of the following criteria:

Also since the very first part of your initial post wasn't addressed: we have numerous other feedback methods you can use. Posting suggestions on our community forum or in our Discord server for example. Links to both are on our Community page. Given that there was no issue for creating a windows installer here before, creating this is appropriate.

Juliasmatius commented 1 year ago

That would be all good except that I have no idea how to use AppVeyor

J5lx commented 1 year ago

Sorry for not replying earlier, I’ve been kinda busy recently. I’m the one who started the installer PR MrStevns mentioned earlier. I have some progress locally which I think is relatively close to being finished. I’ll check how much still needs to be done and depending on how much it is I’ll either finish it myself in the next few days or I’ll just update the PR with the current work in progress so that you can continue from there.

LxeC commented 1 year ago

Inno Setup should be easy and free to use for Windows https://github.com/jrsoftware/issrc

J5lx commented 1 year ago

Earlier I updated the PR with my changes. It’s pretty close to completion now and there are only a few things left to do (notably the localization setup). For details see https://github.com/pencil2d/pencil/pull/848#issuecomment-1668958466. You’re welcome to help with some of the remaining work if you like, just leave a message before you start so that no work is done twice.

Since everyone seems to love dumping their favourite installer software in this issue, I’ll also share some thoughts on these different options as well as the ones I considered:

You can probably see why I went with WiX. It’s actively maintained, produces very robust installers, is easy to customize since XML/C/C++ are already familiar to me, and allows me to get rid of a lot of boilerplate. If you think there’s a compelling reason to use something else, I’m happy to hear it, but you’ll have to give some context and not just dump a link in this issue.