search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.45k stars 272 forks source link

Select tool glitches after erasing content #1764

Closed MrStevns closed 1 year ago

MrStevns commented 1 year ago

Issue Summary

Several users has been mentioning issues surrounding the select tool, namely: https://discuss.pencil2d.org/t/a-drawing-decides-to-come-back-and-move-down-when-i-erase-it-cut-it-with-the-selection-tool/7196/8 https://discuss.pencil2d.org/t/deleting-selection-error/6530

The bug occurs after having erased the content of the selection once, and having the cursor inside the selected area.

Actual Results

Either the old selection re-appears or causes a selection to appear but offset from the cursor position.

Expected Results

The selection should always start from the cursor position.

### Video or Image Reference ### Steps to reproduce 1. Create a selection 2. Move the cursor inside the selected area 3. Press backspace to delete the selection 5. Create a new selection Notice two things happening, the cursor is still showing its previous selected state and depending on where you had the mouse, the selection has been dragged or has been offset from its expected position. ### System Information + Pencil2D Version: Master: ba40ec95b45cbdfdedd98c38d71d3364d8cb9fa8 + Operating System: Mac OS
Jose-Moreno commented 1 year ago

@MrStevns Hi! Thank you for the report and the PR 💪 I had a similarly related issue that was reported on discord a while back but I forgot to open a ticket in GH.

I'm unsure if the problem I experienced was caused by the same root problem for the current issue, or if it's a different issue so I'll leave the video I recorded before for your inspection.

Please let me know at your convenience If I should submit a different report for this. Thanks for the hard work! 🙏

https://github.com/pencil2d/pencil/assets/4912907/5d806f48-87c3-4e97-892c-0d752fba05d5

MrStevns commented 1 year ago

Hi Jose, yes that is indeed the problem that has been fixed 😄

Jose-Moreno commented 1 year ago

@MrStevns That's great then. One less issue to worry about 😄 Thank you for your prompt reply and for all the hard work. Cheers!