search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.45k stars 272 forks source link

DevOps | Removing macdeployqtfix #1809

Closed chchwy closed 4 months ago

chchwy commented 7 months ago

Currently, we use a third party tool 'macdeployqtfix' (link) to fix the broken official deployment tool 'macdeployqt' when working with early Qt5 versions.

However, in recent Qt versions, it seems that this extra step is no longer necessary.

I just verified that when using the bundled 'macdeployqt' in Qt 5.15.2, there is nothing to fix in the Mac app bundle. So it should be safe to remove macdeployqtfix from our deployment process.

The only scenario where 'macdeployqtfix' may still be required is for the legacy Mac build, which is built with Qt 5.6 as far as I know.

chchwy commented 4 months ago

Closing as it's merged in https://github.com/pencil2d/pencil/pull/1823