search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.45k stars 272 forks source link

Improve preferences layout for long translations #1856

Closed J5lx closed 3 months ago

J5lx commented 3 months ago

Fixes #1850 by simply removing the size restriction altogether. I couldn’t think of a good reason to keep it. I also made the dialog a little bigger by default and made some changes to the “tab bar” to avoid cutting off long translations.

Before:

image

After:

image

J5lx commented 3 months ago

That’s odd, I’m definitely not seeing that on Linux. On Windows, Qt 5 has that issue but not Qt 6, maybe that’s the issue? I’ll see if I can figure out what’s going on there.

The placement of the tabs are also now misaligned

You mean the left-alignment? That’s what the size hint is supposed to deal with. It’s not technically new though. It’s not as noticeable in the English version because of the relatively short length of the labels, but in other languages it can be painfully obvious (see my “before” screenshot in the PR description).

MrStevns commented 3 months ago

That’s odd, I’m definitely not seeing that on Linux. On Windows, Qt 5 has that issue but not Qt 6, maybe that’s the issue? I’ll see if I can figure out what’s going on there.

Ah good point, I was testing with Qt 5 but even with my Qt 6 build the issue remains. I've tested with 6.6.2 and 6.7.0.

You mean the left-alignment? That’s what the size hint is supposed to deal with. It’s not technically new though. It’s not as noticeable in the English version because of the relatively short length of the labels, but in other languages it can be painfully obvious (see my “before” screenshot in the PR description).

Ah right.. forget that part then.

J5lx commented 3 months ago

I added some changes that, at least on Windows, seem to make the size hint behave as intended, PTAL.

MrStevns commented 3 months ago

btw. shouldn't the PR point to the release branch or are we simply not applying more bug fixes to the release?

chchwy commented 3 months ago

btw. shouldn't the PR point to the release branch or are we simply not applying more bug fixes to the release?

Target the master branch since the change was made based on the master branch. And then I will cherry-pick this to the release branch.

J5lx commented 3 months ago

Since the change is for both branches I figured I might as well target master so it can then be cherry-picked to the release branch. But ofc I could also do it the other way around for any future changes if that’s more convenient.