search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.45k stars 272 forks source link

Fill misbehaving in some cases #1864

Closed MrStevns closed 1 month ago

MrStevns commented 2 months ago

Issue Summary

Filling with "expand fill" feature disabled, causes the fill to misbehave in some cases. The following image comes from discord https://discord.com/channels/342369662710972417/395346048727515137/1264995838820618262 image

It's clear that while parts of the image has been filled, the filling algorithm is missing some spots that should have been filled. I verified this with the project file myself. fill-behavior-bug-report

Actual Results

The fill ignores parts of the drawing.

Expected Results

The fill should surround the drawing, or at least fill according to its boundary.

Steps to reproduce

  1. Open attached project
  2. Scrub to keyframe 13 on layer "Bitmap Layer"
  3. Select fill tool
  4. remove checkmark from "Expand fill"
  5. fill according to the gif shown above.

project.zip

System Information

Version: 0.7.0.911 commit: 7e83608a957dfeacc739ec0a09a89291de0d4e6b date: 2024-06-19_01:01:26

Operating System: macOS 12.7 CPU Architecture: x86_64 Qt Version: 5.15.13