issue-1864: Fix fill misbehaving when drawing was partly outside border

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.

http://pencil2d.org

GNU General Public License v2.0

1.48k stars 273 forks source link

issue-1864: Fix fill misbehaving when drawing was partly outside border #1865

Closed MrStevns closed 3 months ago

MrStevns commented 3 months ago

Fixes #1864

MrStevns commented 3 months ago

In addition to fixing the bug not being filled correct, it will also now take the border into account properly, as talked about here. https://discord.com/channels/342369662710972417/342670204351938562/1265361324456804362

fill-behavior-fix2

MrStevns commented 3 months ago

Thanks for reviewing Jacob!

I've addressed your comment and made some small adjustments in order make the bucket tool always fills within the bounds. The logic for that was already there, it was just being ignored because we had a contradictory check, so I simplified it a bit and now that works too.

In practice this just means that when you try to fill outside the bounds of the image, it will move the fill point inside, rather than ignore the fill command.