search

pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.48k stars 273 forks source link

[BUG] Onion Skin does not show non-contiguous keyframes #449

Closed MicSc closed 8 years ago

MicSc commented 8 years ago

--Pictures-- pencil_bug1 pencil_bug2 pencil_bug3 --Steps to reproduce-- 1)Activate Onion Skinning 2)Create keyframe(s) and draw something in it 3)Create or move a keyframe so that there is a gap of one or more frames between keyframes.

If the gap is two frames or longer, the onion skin of the previous keyframes will not be visible, if it is one frame only the second-level onion skin will be faintly visible.

The reason appears to be that the onion skin counts and displays absolute (global) frames instead of keyframes.

--Expected Results-- The default behaviour of Pencil2D 0.5.4b, onion skin displays previous/following keyframes regardless of any gaps.

--System Information-- Pencil2D Nightly Build 15 Jan 2016 Windows 10 64bit Intel Mobile Core 2 Duo P8600 @2.40GHz Intel GMA 4500MHD (GM45) 4 GB RAM

feeef commented 8 years ago

There is a button (maybe not obvious enough) to switch from absolute to relative keyframe onion skin positions. If you over it with your mouse, it says "Toggle match keyframes".

screenshot from 2016-01-21 08-58-55

The feature is there and maybe we should improve the UI to make it more obvious.

MrStevns commented 8 years ago

Yea i have been thinking about ways to make this more obvious, because it's current UI doesn't say much when you press it, unless you have one of the "show onion skin" displays enabled and look at the timeline. Maybe it should have two different images, one for relative and another for absolute.

feeef commented 8 years ago

Feel free to update this UI as you wish @CandyFace . I am not very good in UI design and you seem to be pretty good in this area. I like what you have done with the colour wheel.

tasaif commented 8 years ago

@MicSc is this resolved then?

MicSc commented 8 years ago

Well now I feel stupid, but yes, I guess this resolves it. Not sure if it should be left up for the suggested UI change or if that should be a new issue?

tasaif commented 8 years ago

Don't worry about it. Please put it in a new issue.