[BUG] Eyedropper Keyboard Shortcut Toggle Behaviour

[Jose-Moreno]

--Issue Overview--

The Eyedropper tool toggle becomes "soft-locked" due to the additional menu focus behaviours after pressing the ALT key for a period of time lesser than 1000 ms without picking a color between the press and the release of the key.

Now the tool won't revert back to it's previously active tool, but you can pick a color afterwards while in the "soft-lock" state. To leave out of it you have click on the active tool icon, select a new tool or press the ALT key a few times.

--Video Demo-- https://www.youtube.com/watch?v=pEVKVmfuJxk&feature=youtu.be

--Steps to reproduce--

Normal Behaviour 1) Select a drawing tool (i.e Pen Tool) 2) Press & hold ALT key 3) Pick a Color 4) Release ALT key

Abnormal Behaviour 1) Select a drawing tool (i.e Pen Tool) 2) Tap rapidly ALT key (i.e Press & Release ALT key) [eyedropper becomes "soft-locked"] 3) Pick a Color 4) Eyedropper still remains as active toggle 5) Press currently selected drawing tool icon OR select a different tool OR Tap the ALT key until the toggle reverts back.

--Expected Results-- The eyedropper toggle state should not change it's behaviour due to a different behaviour invoked by the same key, particularly when the application shifts focus over a different part of the interface.

--System Information-- Pencil2D Nightly Build 15 Jan 2016 / Nightly Build 16 Feb 2016 (Run & built with Qt Creator 3.4.2 based on Qt 5.5.0) Windows 7 64bits SP1 ATI Radeon HD 6770 1GB AMD Phenom II X4 965 BE 3.4 GHZ 4 GB RAM

[MrStevns]

Do you still experience this, because I can't reproduce it?

[Jose-Moreno]

@CandyFace I think this was fixed by Matt, but I'm not sure now. I'll test it again along with the other one and if anything I'll close it. Thanks :smile:

[Jose-Moreno]

@CandyFace Just tested on with the latest code. This is still happening to me on Windows. The thing is that you have to tap the alt key to basically get the focus on the menu, and once you try to pick the color the menu focus exits and the tool becomes locked until you press ALT twice, and sometimes you just have to press the shortcut for the tool again.

[MrStevns]

@Jose-Moreno Ah right, I was able to reproduce it now. You have to hold down the mouse button prior to you rapidly pressing the alt key, then release the mouse button. Now I end up with the same problem you described, it will be stuck in its color picking action.

I'll see what I can do about it :)

edit: baah, forget what I said, this behaviour seems to be periodic. I can't reproduce it every time...

[Jose-Moreno]

[2018 Review] @CandyFace This issue still happens. It's easier than before to reproduce. Just tap rapidly the alt key. this will make the color picker to be invoked while activating the "menu" focus behavior. Pick a color, it gets locked, pressing alt rapidly twice in succession unlocks it. So we either change the "temp access" hotkey for the eyedropper or fix it so that only after a certain amount of milliseconds (higher than the menu focus behavior) so the alt key invokes the picker.

This must be the reason why Krita has their eyedropper temp access assigned to the ctrl key... which is annoying.