pencil2d / pencil

Pencil2D is an easy, intuitive tool to make 2D hand-drawn animations. Pencil2D is open source and cross-platform.
http://pencil2d.org
GNU General Public License v2.0
1.45k stars 272 forks source link

[REQUEST] Triggering a popup window (save before closing) when interacting with timeline #771

Open Kaikogf opened 6 years ago

Kaikogf commented 6 years ago

--Issue Summary--

when adding a new sound layer, and importing a sound file and playing back with it and then decide to close Pencil2D, it will not ask for saving the actual changes and will close immediately.

--Actual Results

Pencil2D will close immediately regards changes on the sound file layers

--Expected Results--

A pop-up window warning of changes on the timeline.

chchwy commented 6 years ago

This is a part of undo/redo improvements, will put this into the 0.7 plan.

Jose-Moreno commented 4 years ago

[2019] This happens when using File > Import > Sound and then letting Pencil2D create the sound layer for you. If you create the sound layer manually and add the file using the "add keyframe" button this does not happen. It seems a specific problem related to the import action.

scribblemaniac commented 4 years ago

As @chchwy said, it is undo/redo related, and should be fixed in @CandyFace's undo/redo rewrite. I am assigning this to him just to make that clearer.