pendo-io / pendo-mobile-sdk

Pendo captures product usage data, gathers user feedback, and lets you communicate in-app to onboard, educate, and guide users to value
https://www.pendo.io
Other
57 stars 2 forks source link

Crash on 3.0.1 #102

Closed dabaicaifen closed 4 months ago

dabaicaifen commented 6 months ago

Platform + Version IOS 17.2

SDK Version Pendo 3.0.1

Framework Native iOS

Describe the bug Pendo crashes when tapping on some screen.

To Reproduce Steps to reproduce the behavior:

  1. Go to my app
  2. Click on some feature
  3. Crash

Expected behavior No crash

Logs Crash report: pendo_crash.txt

orendayan commented 6 months ago

Hi @dabaicaifen, A few things that might help us to reproduce:

Thanks

MikePendo commented 6 months ago

@dabaicaifen The crash is related to our new implementation of swiftui support. It's very hard to spot it without reproducing.

  1. Any chance your app is on App Store and we can try it.
  2. if you change your initialization with the following, as a work around : (will it still happen)
    let options = PendoOptions()
    options.scanDepth = 15
    PendoManager.shared().setup(appKey, with: options)
dabaicaifen commented 6 months ago

The following is the log right before the crash


[Pendo] [Tuesday, January 9, 2024 at 10:33 AM] ✅ 
[Pendo] [Tuesday, January 9, 2024 at 10:33 AM] ✅ -D- Sent analytics buffer successfully (id: 3) to server
[Pendo] [Tuesday, January 9, 2024 at 10:33 AM] ✅ -I- Finished background task '129'
[Pendo] [Tuesday, January 9, 2024 at 10:33 AM] ✅ -D- sent analytics buffer (id: 3) to server successfully.
[Pendo] [Tuesday, January 9, 2024 at 10:33 AM] ✅ Screen changed
[Pendo] [Tuesday, January 9, 2024 at 10:33 AM] ✅ Starting SwiftUI scan from topMostController: <_TtGC7SwiftUI19UIHostingControllerV8Dayforce12MessagesView_: 0x111902800>
[Pendo] [Tuesday, January 9, 2024 at 10:33 AM] ✅ A. elements found: 0 for view: nil
[Pendo] [Tuesday, January 9, 2024 at 10:33 AM] ✅ A. elements found: 0 for view: <UISplitViewController: 0x109e5a870>
MikePendo commented 6 months ago

@dabaicaifen Any chance your app is on App Store and we can try it? We think we know where the issue might happen(as we have another customer that has the same issue) but we would like to verify it, as we cant reproduce it on our side

MaximShnirman commented 6 months ago

added backlog to this one since i suspected there is another similar issue under work at the moment

MaximShnirman commented 6 months ago

@dabaicaifen pls try fetching version 3.0.2 which should include a fix for this issue

MaximShnirman commented 6 months ago

closing this for now, pls reopen in case this still happens

dabaicaifen commented 5 months ago

hi @MaximShnirman , I tried 3.0.2 today, and it still crashes on my side. The debug message showed the same.

MikePendo commented 5 months ago

@dabaicaifen its hard for us to say exactly what the exact reason for the crash.

  1. is you app available on Appstore so we could try to reproduce the issue OR
  2. will it be possible for you to add us as test Flight user so we could try to reproduce the issue OR
  3. maybe u can create minimal sample code snippets so we could try to reproduce the issue

In additions is your app crashing on Swiftui page or UIKit page. In 3.1 release we will eliminate any code access that related to swiftUI when accessing UIKit page

MaximShnirman commented 5 months ago

@dabaicaifen can you please add the new crash log after updating to 3.02? (not the debug log)

dabaicaifen commented 5 months ago

Hi @MaximShnirman , I'm happy to help, I asked my product to contact Pendo team.

MikePendo commented 5 months ago

@dabaicaifen We got a response from you PM. And its seems you cant reproduce it any more. Is that the case? If yes can we close the issue If not we will need to have sample app to reproduce the issue as we didnt manage to reproduce it on our side with the same stack trace

dabaicaifen commented 5 months ago

@dabaicaifen We got a response from you PM. And its seems you cant reproduce it any more. Is that the case? If yes can we close the issue If not we will need to have sample app to reproduce the issue as we didnt manage to reproduce it on our side with the same stack trace

Hi Mike, that is not my PM. I have a work item in current sprint to provide your team a Test Flight build.

MikePendo commented 4 months ago

@dabaicaifen we reproduced the crash will be fixed in next HF release

dabaicaifen commented 4 months ago

@dabaicaifen we reproduced the crash will be fixed in next HF release

Thanks Mike, may I ask if Pendo can include the privacy manifest in this HF release? https://developer.apple.com/documentation/bundleresources/privacy_manifest_files

MikePendo commented 4 months ago

We will its in our road map but not in the HF (I think it will go to 3.2)

dabaicaifen commented 4 months ago

We will its in our road map but not in the HF (I think it will go to 3.2)

may I ask when the 3.2 is planned to release?

MikePendo commented 4 months ago

I dont have an exact day right now. Let's do the following (you are not the first client who is asking for that). Can you please open a separate issue for that?

MikePendo commented 4 months ago

@dabaicaifen 3.1.1 sdk was just release, please note we didnt managed reproduce the exact stack trace of you crash. We discovered a similar crash to yours that seems to be the root cause. If you have any sample project you want us to try or exact scenario on you app please share