pendo-io / pendo-mobile-sdk

Pendo captures product usage data, gathers user feedback, and lets you communicate in-app to onboard, educate, and guide users to value
https://www.pendo.io
Other
57 stars 2 forks source link

App 83565 native with flutter components #133

Closed noambartouv closed 2 months ago

noambartouv commented 3 months ago

This change is Reviewable

MikePendo commented 3 months ago

other/native-with-flutter-components.md line 202 at r1 (raw file):

<br>

Using Swift, to access the PendoSDK.h, include it in the Bridging-Header.h of your app, adding: <br> `#import "PendoSDK.h"`

@noambartouv can we please verify if we need the Bridging header i.e cant we use just the module? NB

MikePendo commented 3 months ago

other/native-with-flutter-components.md line 253 at r1 (raw file):

@import Flutter;
@import Pendo;
#import "PendoSDK.h"

I dont think you need header and the module if its not .mm lets use only the module

MikePendo commented 3 months ago

other/native-with-flutter-components.md line 1 at r1 (raw file):

# Native application with Flutter components

@noambartouv I am confused. The easiest flow that we currently can support is Flutter with Native. i.e initiate the SDK in Flutter and call any native api from native. That will cost a zero effort from the client. Your description here is installing the SDK on Native I think we should go the other way around

MikePendo commented 3 months ago

other/native-with-flutter-components.md line 117 at r1 (raw file):

        // connect to Pendo's server
        Pendo.setup(
        this,

what is this?

MikePendo commented 3 months ago
:lgtm:
udilevin commented 3 months ago

other/native-with-flutter-components.md line 316 at r1 (raw file):

Previously, noambartouv wrote…
verified - no override keyword needed

Please check https://stackoverflow.com/questions/70810646/appdelegate-swift-overriding-declaration-requires-an-override-keyword

udilevin commented 3 months ago
:lgtm:
pendo-ops commented 3 months ago

Failed pendo.io/jira-ref check. Please correct Jira references in the following commits:

e787c6c

randmaayan commented 2 months ago

[merge]

pendo-ops commented 2 months ago

All JIRA issue transitioned/labeled.

Branch APP-83565-native-with-flutter-components deleted