pendo-io / pendo-mobile-sdk

Pendo captures product usage data, gathers user feedback, and lets you communicate in-app to onboard, educate, and guide users to value
https://www.pendo.io
Other
57 stars 2 forks source link

APP-108222_simplified_integration #171

Open MikePendo opened 2 weeks ago

MikePendo commented 2 weeks ago

This change is Reviewable

MikePendo commented 4 days ago

android/pnddocs/flutter-android.md line 122 at r1 (raw file):

Previously, noambartouv wrote…
Ignore the line break

I remover the Note. I think the rest is ok

MikePendo commented 4 days ago

android/pnddocs/flutter-android.md line 124 at r1 (raw file):

Previously, noambartouv wrote…
Maybe this should also be mentioned (or moved) at the top of the page in the requirements section? The same applies to AutoRoute on both the Android and iOS integration pages. So e.x. - If using GoRouter: 13.0 or higher

thi requirement is only if they use them, its not a general requirement

MikePendo commented 4 days ago

android/pnddocs/flutter-android.md line 124 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…
thi requirement is only if they use them, its not a general requirement

you think it still should be in front ?

MikePendo commented 4 days ago

android/pnddocs/flutter-android.md line 133 at r1 (raw file):

Previously, MaximShnirman (Maxim Shnirman) wrote…
מwhat is addRouterToPendoObserver()??

the old one removing it

MikePendo commented 4 days ago

android/pnddocs/flutter-android.md line 155 at r1 (raw file):

Previously, DavidPendo wrote…
We can point here to have a RouterConfig variable i.e ``` final RouterConfig _routerConfig = AppRouter().config()...addPendoListenerToDelegate(); ```

I dont know tried to stick more to auto_rourte docs:https://pub.dev/packages/auto_route:

class App extends StatelessWidget {
  // make sure you don't initiate your router
  // inside of the build function.
  final _appRouter = AppRouter();

  @override
  Widget build(BuildContext context){
    return MaterialApp.router(
      routerConfig: _appRouter.config(),
    );
  }
}
udilevin commented 3 days ago

ios/pnddocs/expo_router-ios.md line 134 at r2 (raw file):

Previously, MaximShnirman (Maxim Shnirman) wrote…
why is this here?....

because it's wrong and @MikePendo fixed it :-)

pendo-ops commented 3 days ago

There was an error adding Reviewers to the Issue APP-108222: An error occured while trying to look up the Jira ticket APP-108222: jira api returned a 429 status code. Please retry request in 112 second(s)