pendo-io / pendo-mobile-sdk

Pendo captures product usage data, gathers user feedback, and lets you communicate in-app to onboard, educate, and guide users to value
https://www.pendo.io
Other
59 stars 2 forks source link

APP-108711 formatting benchmark files #180

Closed MaximShnirman closed 2 months ago

MaximShnirman commented 2 months ago

This change is Reviewable

MikePendo commented 2 months ago

README.md line 74 at r1 (raw file):


- [Native benchmarks](https://github.com/pendo-io/pendo-mobile-sdk/benchmarks/NativePerformanceBenchmarks.md)
- [Flutter benchmarks](https://github.com/pendo-io/pendo-mobile-sdk/benchmarks/FlutterPerformanceBenchmarks.md)

that doesnt work (maybe it should be relative). please verify on GitHub

MikePendo commented 2 months ago

benchmarks/FlutterPerformanceBenchmarks.md line 10 at r1 (raw file):

|     :---:      |     :---:   |     :---:     |    :---:     |   
|    Flutter     |    103 KB   | (~) 60-200KB  |   (~) 10%    |

how that possible that size on native will be that much bigger than the size on flutter(x20), eventually its the same binary?

udilevin commented 2 months ago

benchmarks/FlutterPerformanceBenchmarks.md line 10 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…
how that possible that size on native will be that much bigger than the size on flutter(x20), eventually its the same binary?

We should add the native size as well (6MB)

MaximShnirman commented 2 months ago

README.md line 74 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…
that doesnt work (maybe it should be relative). please verify on GitHub

this doesnt work cause its on a side branch and not on the main branch AFAIK

MaximShnirman commented 2 months ago

benchmarks/FlutterPerformanceBenchmarks.md line 9 at r1 (raw file):

Previously, naorlevi (pippoTLV) wrote…
Is 10% considered low? medium? In the Native benchmark we just mention low which is a bit easier to grasp.

right, tho here we do not have that data. what do you suggest?

DavidPendo commented 2 months ago

README.md line 74 at r1 (raw file):

Previously, MaximShnirman (Maxim Shnirman) wrote…
this doesnt work cause its on a side branch and not on the main branch AFAIK

@MaximShnirman, it should be a relative path

DavidPendo commented 2 months ago

benchmarks/FlutterPerformanceBenchmarks.md line 9 at r1 (raw file):

Previously, MaximShnirman (Maxim Shnirman) wrote…
right, tho here we do not have that data. what do you suggest?

Let's use the same approach as for native using verbose description LOW

MaximShnirman commented 2 months ago

benchmarks/FlutterPerformanceBenchmarks.md line 10 at r1 (raw file):

Previously, MaximShnirman (Maxim Shnirman) wrote…
native side data appear on native file (link is at the bottom) size wise - yes, this is the size

done

MikePendo commented 2 months ago

benchmarks/FlutterPerformanceBenchmarks.md line 12 at r3 (raw file):


<b>\*</b> Slight CPU impact may occur during app launch or UI-intensive operations.
<b>\*\*</b> 103KB reffers to the Flutter plugin size while iOS native SDK size is ~6MB, Android native SDK size is ~3MB.

non blocking BUT I still think it should be more clear (i.e like native), in the end the flutter devs should see exactly how much it adds to their final app and not look for it between the lines

udilevin commented 2 months ago

:lgtm:[merge]

pendo-ops commented 2 months ago

All JIRA issue transitioned/labeled.

Branch APP-108711_benchmarks deleted