pendo-io / pendo-mobile-sdk

Pendo captures product usage data, gathers user feedback, and lets you communicate in-app to onboard, educate, and guide users to value
https://www.pendo.io
Other
57 stars 2 forks source link

APP-76862 Swiftui update docs #30

Closed MikePendo closed 1 year ago

MikePendo commented 1 year ago

This change is Reviewable

pendo-ops commented 1 year ago

Failed pendo.io/jira-ref check. Please correct Jira references in the following commits:

6d839a4

udilevin commented 1 year ago

pnddocs/swiftui.md line 53 at r1 (raw file):

                    Text("Text")
                }
            }

Let's wait with these instructions. I have an alternate idea. Let's discuss.

pendo-ops commented 1 year ago

Failed pendo.io/jira-ref check. Please correct Jira references in the following commits:

6d839a4 faa4427

cohenam commented 1 year ago

[checks]

cohenam commented 1 year ago

[check]

pendo-ops commented 1 year ago

Okay, All checks were run. Did not encounter any errors.

MikePendo commented 1 year ago

[check]

pendo-ops commented 1 year ago

Okay, All checks were run. Did not encounter any errors.

MikePendo commented 1 year ago

pnddocs/swiftui.md line 3 at r3 (raw file):

Previously, noambartouv wrote…
What does the "(For Iphones)" mean? This is swiftUI, what other phones would it be?

we didn't have proper tests for iPads

MikePendo commented 1 year ago

pnddocs/swiftui.md line 3 at r3 (raw file):

Previously, noambartouv wrote…
What will happen when iOS 17 comes out? Should we change the text from iOS 15 and 16 change to iOS 15 or newer?

I dont know, we need to test for iOS 17

MikePendo commented 1 year ago

pnddocs/swiftui.md line 35 at r3 (raw file):

Previously, noambartouv wrote…
When do our customers use this? Custom views? (to me it's not clear) What does enabling Pendo mean?

what do u suggest? we have code example later on

MikePendo commented 1 year ago

pnddocs/swiftui.md line 90 at r3 (raw file):

Previously, noambartouv wrote…
Grammer fix: If you don't add accessibility modifiers the OS will assign default values to the UI elements in your app. (might be worth changing accessibility to accessibility labels (not aware that the OS sets default values for identifiers or hints)

Done

MikePendo commented 1 year ago

pnddocs/swiftui.md line 91 at r3 (raw file):

Previously, noambartouv wrote…
I think what you were trying to say something like: "Accessibility identifiers, accessibility labels, and accessibility hints are all supported and can be used by Pendo for unique identification."

Done

MikePendo commented 1 year ago

pnddocs/swiftui.md line 3 at r3 (raw file):

Previously, noambartouv wrote…
Then it should say that: The full codeless solution is supported by iOS 15 and above. Screen navigation tracking is available from iOS 13. (Testing has focused on iPhones. iPads have yet to be tested thoroughly)

@noambartouv its to long...

MikePendo commented 1 year ago

pnddocs/swiftui.md line 3 at r3 (raw file):

Previously, noambartouv wrote…
IOS 17 is currently beta. I think we should just say iOS 15 and newer it the docs and make sure do perform proper testing for new OS versions before their release (we usually do as far as I remember)

and if iOS 17 will not work? u suggest to change the docs?

MikePendo commented 1 year ago

pnddocs/swiftui.md line 35 at r3 (raw file):

Previously, noambartouv wrote…
I now watched the video. This should probably say: To support SwiftUI the Pendo SDK requires you to apply the`enableSwiftUI()` modifier on each one of the rootViews in your app. See example below:

but in general u will have only one rootView. OR u might have

MikePendo commented 1 year ago

pnddocs/swiftui.md line 35 at r3 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…
but in general u will have only one rootView. OR u might have

Done

MikePendo commented 1 year ago

pnddocs/swiftui.md line 110 at r3 (raw file):

Previously, noambartouv wrote…
I don't understand this sentence. I understand SwiftUI is contained within a UIHostingController but don't understand the general context here. Guessing that maybe we're talking about transitioning an app from UIKit to include SwiftUI as well.

its SwiftUI inside uikit

MikePendo commented 1 year ago

pnddocs/swiftui.md line 3 at r3 (raw file):

Previously, noambartouv wrote…
Maybe change the term "Screen tracking" to "Screen navigation tracking?"

not sure how its better

noambartouv commented 1 year ago

[merge]

MikePendo commented 1 year ago

[checks]

pendo-ops commented 1 year ago

All JIRA issue transitioned/labeled.

Branch APP-76862 deleted