Closed MikePendo closed 1 year ago
Failed pendo.io/jira-ref check. Please correct Jira references in the following commits:
pnddocs/swiftui.md
line 53 at r1 (raw file):
Text("Text") } }
Let's wait with these instructions. I have an alternate idea. Let's discuss.
[checks]
[check]
Okay, All checks were run. Did not encounter any errors.
[check]
Okay, All checks were run. Did not encounter any errors.
pnddocs/swiftui.md
line 3 at r3 (raw file):
What does the "(For Iphones)" mean? This is swiftUI, what other phones would it be?
we didn't have proper tests for iPads
pnddocs/swiftui.md
line 3 at r3 (raw file):
What will happen when iOS 17 comes out? Should we change the text from iOS 15 and 16 change to iOS 15 or newer?
I dont know, we need to test for iOS 17
pnddocs/swiftui.md
line 35 at r3 (raw file):
When do our customers use this? Custom views? (to me it's not clear) What does enabling Pendo mean?
what do u suggest? we have code example later on
pnddocs/swiftui.md
line 90 at r3 (raw file):
Grammer fix: If you don't add accessibility modifiers the OS will assign default values to the UI elements in your app. (might be worth changing accessibility to accessibility labels (not aware that the OS sets default values for identifiers or hints)
Done
pnddocs/swiftui.md
line 91 at r3 (raw file):
I think what you were trying to say something like: "Accessibility identifiers, accessibility labels, and accessibility hints are all supported and can be used by Pendo for unique identification."
Done
pnddocs/swiftui.md
line 3 at r3 (raw file):
Then it should say that: The full codeless solution is supported by iOS 15 and above. Screen navigation tracking is available from iOS 13. (Testing has focused on iPhones. iPads have yet to be tested thoroughly)
@noambartouv its to long...
pnddocs/swiftui.md
line 3 at r3 (raw file):
IOS 17 is currently beta. I think we should just say iOS 15 and newer it the docs and make sure do perform proper testing for new OS versions before their release (we usually do as far as I remember)
and if iOS 17 will not work? u suggest to change the docs?
pnddocs/swiftui.md
line 35 at r3 (raw file):
I now watched the video. This should probably say: To support SwiftUI the Pendo SDK requires you to apply the`enableSwiftUI()` modifier on each one of the rootViews in your app. See example below:
but in general u will have only one rootView. OR u might have
pnddocs/swiftui.md
line 35 at r3 (raw file):
but in general u will have only one rootView. OR u might have
Done
pnddocs/swiftui.md
line 110 at r3 (raw file):
I don't understand this sentence. I understand SwiftUI is contained within a UIHostingController but don't understand the general context here. Guessing that maybe we're talking about transitioning an app from UIKit to include SwiftUI as well.
its SwiftUI inside uikit
pnddocs/swiftui.md
line 3 at r3 (raw file):
Maybe change the term "Screen tracking" to "Screen navigation tracking?"
not sure how its better
[merge]
[checks]
This change is