pendo-io / pendo-mobile-sdk

Pendo captures product usage data, gathers user feedback, and lets you communicate in-app to onboard, educate, and guide users to value
https://www.pendo.io
Other
57 stars 2 forks source link

App 80331 #32

Closed udilevin closed 1 year ago

udilevin commented 1 year ago

This change is Reviewable

MikePendo commented 1 year ago

pnddocs/expo.md line 80 at r1 (raw file):


```typescript
    const PendoNavigationContainer = WithPendoReactNavigation(NavigationContainer);    

@udilevin I am slightly confused, in the previous integration withPendoRN we had an option to provide parameters like nativeIDs etc where is the option here? can u add a sample code as well?

MikePendo commented 1 year ago

pnddocs/expo.md line 77 at r1 (raw file):

Wrap `NavigationContainer` with  `WithPendoReactNavigation` HOC

This whole part looks like a code BUT it not

Code quote:

 Wrap `NavigationContainer` with  `WithPendoReactNavigation` HOC
MikePendo commented 1 year ago

pnddocs/expo.md line 83 at r1 (raw file):

replace `NavigationContainer` tag with `PendoNavigationContainer` tag

This whole part looks like a code but its not

Code quote:

replace `NavigationContainer` tag with `PendoNavigationContainer` tag
MikePendo commented 1 year ago

pnddocs/expo.md line 80 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…
@udilevin I am slightly confused, in the previous integration `withPendoRN` we had an option to provide parameters like `nativeIDs` etc where is the option here? can u add a sample code as well?

Sorry saw it

MikePendo commented 1 year ago

pnddocs/expo_native_navigation.md line 55 at r1 (raw file):

In the application main file (App.js/.ts/.tsx), add the following code:
```javascript
Navigation.events().registerAppLaunchedListener(() => {

I forgot why we need to wrap it with Navigation.events().registerAppLaunchedListener( and not just call it as is (NON BLOCKING)

MikePendo commented 1 year ago

pnddocs/expo_native_navigation.md line 77 at r1 (raw file):

## Limitations 
Please note **Expo Go** is not supported by Pendo because Pendo SDK has a native plugin which is not part of the Expo Go app.
Pendo can be used in development builds *only*. 

is only in correct place? for some reason .md doest show it as bold.

MikePendo commented 1 year ago
:lgtm:
MikePendo commented 1 year ago
:lgtm:
pendo-ops commented 1 year ago

All JIRA issue transitioned/labeled.

Branch APP-80331 deleted