APP-82169 added missing instructions

[orendayan]

This change is 

[MikePendo]

ios/pnddocs/rnn-ios.md line 26 at r1 (raw file):

3. #### Add a **bridging header** as described in <a href="https://developer.apple.com/documentation/swift/imported_c_and_objective-c_apis/importing_objective-c_into_swift" target="_blank">this Apple documentation</a>.
    Add the following import statement to the bridging header:  
    `@import Pendo;`

@orendayan I know its not your pr BUT @udilevin can u please remind me why we need that step?

[MikePendo]

ios/pnddocs/rnn-ios.md line 108 at r1 (raw file):

//for objc++(.mm file) please add this import
#import <Pendo/Pendo.h>

@orendayan lets have a better explanation in 2. like "In Appdelegate file import Pendo and change application:openURL:options". Otherwise its not clear where the import is going to?

[MikePendo]

ios/pnddocs/rnn-ios.md line 102 at r1 (raw file):

      Under App Target > Info > URL Types, create a new URL by clicking the + button.  
      Set **Identifier** to pendo-pairing or any name of your choosing.  
      Set **URL Scheme** to `YOUR_SCHEME_HERE`.

@udilevin there were an image with steps explanation (at least we still have it in native). That explains it. I am not sure why u have removed it

[orendayan]

ios/pnddocs/rnn-ios.md line 108 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…

@orendayan lets have a better explanation in 2. like "In Appdelegate file import Pendo and change application:openURL:options". Otherwise its not clear where the import is going to?

Done.

[udilevin]

ios/pnddocs/rnn-ios.md line 26 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…

@orendayan I know its not your pr BUT @udilevin can u please remind me why we need that step?

Don't think we need it for RN/RNN

[udilevin]

ios/pnddocs/rnn-ios.md line 102 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…

@udilevin there were an image with steps explanation (at least we still have it in native). That explains it. I am not sure why u have removed it

There were no images in rn/rnn.

[MikePendo]

ios/pnddocs/rnn-ios.md line 26 at r1 (raw file):

Previously, udilevin (Udi Levin) wrote…

Don't think we need it for RN/RNN

@orendayan please lets remove it

[MikePendo]

ios/pnddocs/rnn-ios.md line 102 at r1 (raw file):

Previously, udilevin (Udi Levin) wrote…

There were no images in rn/rnn.

[MikePendo]

ios/pnddocs/rnn-ios.md line 108 at r1 (raw file):

Previously, orendayan (Oren Dayan) wrote…

Done.

In Appdelegate file import Pendo and add or modify the function application:openURL:options: That's sounds better AND lets remove this comment //for objc++(.mm file) please add this import As it will be done for objc and objc++ (just make sure it works for objc the same way it works in objc ++) if not we will need to split split @import Pendo for objc and and #import <Pendo/Pendo.h> for objc++

[udilevin]

ios/pnddocs/rnn-ios.md line 108 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…

`In Appdelegate file import Pendo and add or modify the function application:openURL:options:` That's sounds better AND lets remove this comment `//for objc++(.mm file) please add this import` As it will be done for objc and objc++ (just make sure it works for objc the same way it works in objc ++) if not we will need to split split `@import Pendo` for objc and and `#import ` for objc++

@orendayan make sure you send these changes to @juliebenjamin to approve the language changes.

[orendayan]

ios/pnddocs/rnn-ios.md line 108 at r1 (raw file):

Previously, udilevin (Udi Levin) wrote…

@orendayan make sure you send these changes to @juliebenjamin to approve the language changes.

@MikePendo really don't know what you meant here

[MikePendo]

ios/pnddocs/native-ios.md line 46 at r4 (raw file):

    @interface AppDelegate ()
    @end

   @interface AppDelegate ()
    @end

redundant

[MikePendo]

ios/pnddocs/rnn-ios.md line 108 at r1 (raw file):

Previously, orendayan (Oren Dayan) wrote…

@MikePendo really don't know what you meant here

your instruction says: #### In AppDelegate file add or modify the function**application:openURL:options**: and on the next line you are showing the following code:

   //for objc++(.mm file) please add this import
   #import <Pendo/Pendo.h>

lets change the instruction to: In Appdelegate file import Pendo and add or modify the function application:openURL:options: And I think its better not to confuse customers with objc++ comments, so we can remove the comment about it, just verify the same import will work on objc

[MikePendo]

[udilevin]

[merge]

[pendo-ops]

Some JIRA issues need reviews:

• APP-82196: Needs Senior Review

[udilevin]

[merge]

[pendo-ops]

Branch merge failed. At least 2 approving reviews are required by reviewers with write access.

[udilevin]

ios/pnddocs/flutter-ios.md line 13 at r5 (raw file):

Previously, MaximShnirman (Maxim Shnirman) wrote…

Why do setup and track requires await?

all needs await...fixed

[udilevin]

[merge]

[pendo-ops]

All JIRA issue transitioned/labeled.

• APP-82169: Jira Issue APP-82169: Changed to Resolved

Branch APP-82169 deleted