pendo-io / pendo-mobile-sdk

Pendo captures product usage data, gathers user feedback, and lets you communicate in-app to onboard, educate, and guide users to value
https://www.pendo.io
Other
57 stars 2 forks source link

APP-88062 adding some scene delegate documentation #71

Closed MaximShnirman closed 11 months ago

MaximShnirman commented 1 year ago

This change is Reviewable

udilevin commented 1 year ago

ios/pnddocs/native-ios.md line 80 at r1 (raw file):

    PendoManager.shared().startSession("visitor1", accountId: "account1", visitorData:[], accountData: [])

this is the wrong objectivec implementation. You need scene willConnectTo and not openURL

udilevin commented 1 year ago

ios/pnddocs/swiftui.md line 58 at r1 (raw file):

}

what about openURL? Will that work with Scenes? @MikePendo

MaximShnirman commented 1 year ago

ios/pnddocs/native-ios.md line 80 at r1 (raw file):

Previously, udilevin (Udi Levin) wrote…
this is the wrong objectivec implementation. You need scene willConnectTo and not openURL

wait, the top one is to run setup call, the bottom is for open URL... what do I miss?

MaximShnirman commented 1 year ago

ios/pnddocs/native-ios.md line 80 at r1 (raw file):

Previously, MaximShnirman (Maxim Shnirman) wrote…
wait, the top one is to run setup call, the bottom is for open URL... what do I miss?

i see now

MikePendo commented 1 year ago

ios/pnddocs/swiftui.md line 58 at r1 (raw file):

Previously, udilevin (Udi Levin) wrote…
what about openURL? Will that work with Scenes? @MikePendo

in our current Implementation we directly call the open url of the app delegate in swift ui. not the scene one.

MikePendo commented 1 year ago

ios/pnddocs/rnn-ios.md line 119 at r2 (raw file):

**ObjectiveC**
```objective-c
   #import <Pendo/Pendo.h>

maybe @import Pendo; as we do it in all the rest of the places

MaximShnirman commented 12 months ago

ios/pnddocs/swiftui.md line 58 at r1 (raw file):

Previously, MikePendo (Michael Rozenblat) wrote…
in our current Implementation we directly call the open url of the app delegate in swift ui. not the scene one.

i think we should keep both for maybe more advanced users? WDYT?

MikePendo commented 11 months ago

ios/pnddocs/swiftui.md line 58 at r1 (raw file):

Previously, MaximShnirman (Maxim Shnirman) wrote…
i think we should keep both for maybe more advanced users? WDYT?

I am not sure what I can add here, we need to look how to call scene delegates open url from swiftUI.

udilevin commented 11 months ago
:lgtm:
udilevin commented 11 months ago

[merge]

pendo-ops commented 11 months ago

All JIRA issue transitioned/labeled.

Branch APP-88062openURL deleted