search

pendo-io / pendo-mobile-sdk

Pendo captures product usage data, gathers user feedback, and lets you communicate in-app to onboard, educate, and guide users to value
https://www.pendo.io
Other
57 stars 2 forks source link

Nuget package for MAUI is missing net8.0 target #82

Closed velocitysystems closed 9 months ago

velocitysystems commented 9 months ago

Platform + Version .NET 8.0

SDK Version 2.22.6.6006

Framework MAUI

Describe the bug NuGet package for the MAUI SDK is missing a net8.0 target. This prevents a MAUI project (with Pendo) from being referenced by a unit test project i.e. xUnit runner.

To Reproduce Steps to reproduce the behavior:

  1. Create an empty MAUI project
  2. Add pendo-maui NuGet package to project
  3. Create an empty xUnit test project with a net8.0 target
  4. Add MAUI project as a project reference to test project

Expected behavior NuGet package should include a net8.0 target, in addition to iOS, Android, Mac Catalyst targets. See an example here for the Microsoft.Maui.Controls.Maps project.

TehilaTaub commented 9 months ago

Thanks for reaching out. We are supporting .net 7.0 so currently .net 8.0 is not supported yet, it is in our roadmap. We will keep you updated with the timeline once we will have it.

velocitysystems commented 9 months ago

Thanks @TehilaTaub. As an interim workaround, can you please add a net6.0 target to the package? This will resolve the issue in the meantime for users on .NET 6.0 and .NET 7.0.

TehilaTaub commented 9 months ago

The current package is compatible with .NET 6.0, and the 3.0 package will be available in a week and compatible with .NET 7.0.

velocitysystems commented 9 months ago

The current package is compatible with .NET 6.0, and the 3.0 package will be available in a week and compatible with .NET 7.0.

The current package is targeted for net6.0-android31.0, net6.0-ios15.0 and net6.0-maccatalyst16.1 but it is missing a target for net6.0. A net6.0 target is required in order to add the MAUI project containing Pendo to a test runner project i.e. with xUnit or NUnit.

For the new package compatible with net7.0, this would mean adding a vanilla net7.0 target to the package.

velocitysystems commented 9 months ago

@TehilaTaub Thanks for adding a vanilla net7.0 target to the latest pendo-maui package! Everything now compiles and works perfectly with an xUnit test runner.