search

pendulum-chain / pendulum-prototype

Pendulum prototype: Second Layer Network for Stellar and the DeFi ecosystem
MIT License
10 stars 6 forks source link

Deposit: unhardcode amount #21

Closed gonzamontiel closed 3 years ago

gonzamontiel commented 3 years ago

In this PR, we implemented a Multi Currency system with two default currencies, that we named Native and USDC. To achieve this, we made use of the Open Runtime Module Library, specifically the pallets orml_tokens and orml_currencies.

The amount from the incoming Stellar Tx is now used to transfer funds (i.e. is not hardcoded anymoere), but the asset/currency is still fixed for the demo, and is always USDC.

andywer commented 3 years ago

This isn't ready to be merged yet, is it? We should turn it back into a draft again.

gonzamontiel commented 3 years ago

I didn't want this branch to grow a lot more, because history would differ a lot from #22. I prefer to merge this only with the Stellar amount unharcoded and create successive PRs to unharcode assets and accountId.

TorstenStueber commented 3 years ago

This branch looks good and the deposit works. We will implement further improvements in subsequent tickets.