search

pendulum-chain / pendulum-solidity-wrapper

A collection of Solidity wrapper contracts emulating common ERC interfaces to grant access to runtime features on Pendulum.
GNU General Public License v3.0
0 stars 0 forks source link

Audit: Missing Events #24

Closed annatekl closed 1 year ago

annatekl commented 1 year ago

Events should be emitted after sensitive changes take place, to facilitate tracking and notify off-chain clients following the contract’s activity.

Paths:

./erc20-wrapper/erc20-wrapper.sol : transfer(), transferFrom(), approve();

Recommendation:

consider emitting events in said functions.

Found in:

db10871f6ec81d74e0afe9e1e49b8f2e143aadc5

annatekl commented 1 year ago

Please add your planning poker estimate with Zenhub @TorstenStueber

annatekl commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @ebma @ashneverdawn