search

pendulum-chain / pendulum-squids

The subsquid squids we use for Pendulum/Amplitude/Foucoco.
GNU General Public License v3.0
0 stars 0 forks source link

Composition zenlink pair not shown properly #38

Closed gianfra-t closed 6 months ago

gianfra-t commented 6 months ago

closes #36

Problem was that new types v12 for storage (and events) where implemented in amplitude given a runtime upgrade. This caused some events to be ignored so that the indexer was not giving the correct values for liquidity

Fococo was also changed to v4, so events and storage types were also changed.

Some minor modification was made to support the new CurrencyId (with token variant) that comes from v12 in amplitude.

gianfra-t commented 6 months ago

We could slightly improve the code by using if-elseif branches instead of multiple ifs because the code could exit earlier instead of doing multiple checks. But this is super minor and probably not worth refactoring right now.

True! let's do this in the new refactor issue, I don't think we will need this anyway since the idea is to get rid of the ifs. I will merge this now.