search

pendulum-chain / pendulum

GNU General Public License v3.0
43 stars 14 forks source link

Update runtimes to `polkadot-v0.9.40` #219

Closed ebma closed 1 year ago

ebma commented 1 year ago

We should update our runtime dependencies to version polkadot-v0.9.38 so that we get rid of some dependency conflicts. For example, we were running into problems because our spacewalk pallets use jsonrpsee with version >0.16.0 but other parachain pallets that are on polkadot-v0.9.37 still use jsonrpsee version 0.15.x (e.g. Zenlink) which then leads to conflicts when importing RPC modules from their pallets.

vadaynujra commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @ashneverdawn @ebma @RustNinja @TorstenStueber

TorstenStueber commented 1 year ago

Maybe it makes sense to even switch to Polkadot version 0.9.40 now – it is already supported by orml.

This would also require a follow up task to not just execute the runtime upgrade but first to redeploy all of our collator nodes.

ebma commented 1 year ago

Sure, we'd just need to double-check the jsonrpsee dependencies but if there is a mismatch, then probably just because the version used in the spacewalk pallets is 'too old' which we can fix easily.

TorstenStueber commented 1 year ago

I created a polkadot-v0.9.40 branch in substrate-stellar-sdk repository so that we are good to go from that side. Probably also need to update dependencies in the other related dependencies:

TorstenStueber commented 1 year ago

For that reason I want to re-estimate. @vadaynujra is such a feature not available (change an estimate)?

b-yap commented 1 year ago

@TorstenStueber including https://github.com/pendulum-chain/spacewalk, right?

b-yap commented 1 year ago

Yes I would think this will be higher than 3. The jump from .37 to .40 is huge.

A few changes I found:

And there's plenty more. Currently on https://github.com/pendulum-chain/oracle-pallet.

TorstenStueber commented 1 year ago

@b-yap yes, also including Spacewalk of course. Seems like I have the power to change the estimate. Shall we change it to 5 then @b-yap, or even 8?

b-yap commented 1 year ago

8 would be fine.

TorstenStueber commented 1 year ago

Alright, done.

Curu24 commented 1 year ago

Hello, will this include --rpc-relay-chain-url functionality?

TorstenStueber commented 1 year ago

@Curu24 Is this a new feature introduced in Substrate recently? Can you refer to it please?

Curu24 commented 1 year ago

@Curu24 Is this a new feature introduced in Substrate recently? Can you refer to it please?

https://github.com/paritytech/cumulus/pull/1585

TorstenStueber commented 1 year ago

Since this feature has been merged already many months ago, it is already included in the polkadot-v0.9.31 branch.

So, it looks to me like the Pendulum nodes would already include this functionality even without this PR.

Curu24 commented 1 year ago

Since this feature has been merged already many months ago, it is already included in the polkadot-v0.9.31 branch.

So, it looks to me like the Pendulum nodes would already include this functionality even without this PR.

Oh, yes, sorry. You're right. I was trying with the older release 0.9.29. With 0.9.37 it works.