pendulum-chain / pendulum

GNU General Public License v3.0
43 stars 15 forks source link

Replace dependency from Forked Zenlink to Original Zenlink once pendulum upgrade polkadot version to polkadot-v0.9.38 #222

Closed RustNinja closed 6 months ago

RustNinja commented 1 year ago

Issue related to https://github.com/pendulum-chain/pendulum/issues/217 and https://github.com/pendulum-chain/pendulum/issues/219 and problem produced by different version of jsonrpsee here is fixed issue in forked version : https://github.com/pendulum-chain/Zenlink-DEX-Module/issues/1

Todo list: once pendulum repo will upgraded to polkadot-v0.9.38 it is good idea to replace dependency from forked version to original version. because original version has a proper dependency of jsonrpsee that does not force us to use a forked version.

https://github.com/pendulum-chain/Zenlink-DEX-Module to https://github.com/zenlinkpro/Zenlink-DEX-Module

vadaynujra commented 1 year ago

@ebma Is this required for the initial integration with Zenlink? If not, do you know when this would be required?

ebma commented 1 year ago

@vadaynujra this is never ever 'required'. It's just nice to have and acts as a reminder of why we had to use a forked version of the Zenlink pallet basically. We might be able to close it in a few weeks, once Zenlink updates their code to 0.9.40 (as we decided to skip upgrading to 0.9.38 and immediately reached for 0.9.40 but this now makes us rely on the fork again, because they didn't update their code to that version yet).

prayagd commented 9 months ago

Moving to icebox

TorstenStueber commented 9 months ago

@ebma @gianfra-t could we actually work on this now with the upgrade to Polkadot v0.9.42?

gianfra-t commented 8 months ago

Yes, actually in the upgrade pr we are already using the zenlinkpro repo.

TorstenStueber commented 8 months ago

Great. So then we can close this ticket once the other PR is merged.