search

pendulum-chain / pendulum

GNU General Public License v3.0
43 stars 13 forks source link

Improve XCM integration tests #293

Open ebma opened 1 year ago

ebma commented 1 year ago

This is a follow-up task to PR #290.

We identified that the integration tests for testing relay-chain transfers via XCM can be improved. We originally adopted these integration tests from Acala, but they added some improvements in the meantime, for example, more flexible fee calculations for asset-hub transfers, see this file, that would make us a little less dependent on hard-coded values.

TODO

We should have another look at Acala's integration tests for relay-chain transfers and try to adopt the latest best-practices.

ebma commented 1 year ago

@pendulum-chain/product I created this very technical ticket. It's more about refactoring and we don't get any new features out of this. It's also not fixing a bug, so not critical. Just nice to have eventually.

vadaynujra commented 1 year ago

@ebma based on your comment I assume this is not required to be completed before this ticket. From an epic pov, would this be more about improving our QA process in general or having a better XCM overview / knowledge?

ebma commented 1 year ago

I'd say this is more about improving the QA process. We could catch some more issues with improving the integration tests. While doing so we might also gain a little extra XCM knowledge but that's more a minor side effect I'd say.

prayagd commented 10 months ago

@ebma Moving this to icebox based on your comment as this nice to have