search

pendulum-chain / pendulum

GNU General Public License v3.0
43 stars 14 forks source link

fix for try-runtime features #386

Closed gianfra-t closed 5 months ago

gianfra-t commented 6 months ago

This PR adds fixes so that the runtimes can be compiled with the try-runtime feature. Also should solve #327. Related to tasks/#64 and the upgrade to 0.9.42. I believe it would be a good idea to first have the capability of testing with try-runtime the upgrade.

This PR also has a small fix regarding this comment

ebma commented 6 months ago

Would you say this is related to #327 then?

gianfra-t commented 6 months ago

Yes! I wasn't aware about that issue. Adding it to the description.

TorstenStueber commented 6 months ago

@gianfra-t since the ticket you mention in your ticket above has been closed, can we open this PR here for review or is it still a draft?

gianfra-t commented 6 months ago

I'm right now merging with main and checking that everything still works.

gianfra-t commented 5 months ago

There is also a Spacewalk dependency in pallets/orml-tokens-management-extension/Cargo.toml and in runtime/integration-tests/Cargo.toml, which should probably also be updated (?)

Thanks for finding this. It mus have been a reference to an even older commit, not sure how it was compiling!

TorstenStueber commented 5 months ago

However, would be good to also get @ebma's opinion here as he commented here on the changes with the RelativeValue.