pendulum-chain / pendulum

GNU General Public License v3.0
43 stars 14 forks source link

addition of spacewalk pallets to pendulum #401

Closed gianfra-t closed 5 months ago

gianfra-t commented 5 months ago

@pendulum-chain/product: This PR adds changes to the node client code that require a redeployment of the collator nodes to take effect. Please ensure that the collator nodes are redeployed after this PR is merged. This is because of the new RPC methods that Spacewalk brings (and genesis config).

Closes #400 .

Changes

This PR is for the addition of all the relevant Spacewalk pallets into the Pendulum runtime. It mostly adopt the same configuration used in Amplitude, except for:

Extra notes

gianfra-t commented 5 months ago

@ebma should we test the functionality of the newly added pallets in something like zombienet/chopsticks? Or is it okay since we already know they work in Amplitude? WDYT

ebma commented 5 months ago

should we test the functionality of the newly added pallets in something like zombienet/chopsticks? Or is it okay since we already know they work in Amplitude? WDYT

I think we should test it but let's rather test the whole runtime when we are about to release. Meaning, I would rather test the runtime once we have the PR to bump spec and transaction versions.

gianfra-t commented 5 months ago

let's rather test the whole runtime when we are about to release.

Makes sense!

gianfra-t commented 5 months ago

Sorry @ebma, I think you need to approve again. I fixed indentations as much as I could and was waiting for the CI.