search

pendulum-chain / pendulum

GNU General Public License v3.0
43 stars 14 forks source link

Change Github workflow to run tests with feature flags #420

Open bogdanS98 opened 4 months ago

bogdanS98 commented 4 months ago

Context

At the moment, our Github workflow is running cargo test without any feature flags. This allows for changes that break benchmarks to pass the pipeline and therefore be merged into the main branch. This will cause building the main branch with runtime-benchmarks feature to fail. The same thing happens for pallets/runtimes (i.e. development runtime) that do not properly declare the try-runtime feature.

Requirement

Pipeline should be changed so that it runs cargo test --features runtime-benchmarks try-runtime

Notes

Before changing the workflow to run tests with the try-runtime feature, development runtime must be removed since it's not used anymore and it's causing errors when built with try-runtime. There's already an open ticket for deleting this runtime here.

bogdanS98 commented 4 months ago

@pendulum-chain/product This is not urgent but would be nice to have it fixed.

prayagd commented 4 months ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber