Remove the custom migration logic from all runtimes

pendulum-chain / pendulum

GNU General Public License v3.0

43 stars 14 forks source link

Remove the custom migration logic from all runtimes #454

Open ebma opened 5 months ago

ebma commented 5 months ago

As part of our efforts to upgrade the dependencies to v0.9.42, we added custom migration logic to all runtimes. Now that these changes are rolled out and all the migrations applied, we can remove that extra logic again.

TODO

Remove the CustomOnRumtimeUpgrade implementations again
Remove the customized dependencies. We had to create forks of some projects in order to be able to modify their migration logic. We can delete those forks again and switch back to the 'official'/upstream dependency versions.

ebma commented 5 months ago

@pendulum-chain/product this is more of a chore but nice-to-have and low effort. We can clean up some unnecessary code and repositories with this.

prayagd commented 5 months ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

gianfra-t commented 2 months ago

I think we can reuse this ticket and remove the custom migration logic after the 1.1.0 upgrade is completed. Otherwise we would need to re-add them soon.

ebma commented 2 months ago

Right, let's do that. I added the ticket as a blocker to the Zenhub dependencies.

vadaynujra commented 6 days ago

@ebma is this possible to be worked on now, or only after the upgrade on Pendulum?

gianfra-t commented 6 days ago

@vadaynujra only once we have updated the runtimes we can remove this extra code. We left this ticket also as a reminder to remove the extra logic after the runtime upgrade that bumps to 1.1.0 is enacted on all runtimes.

In any case, this is not blocking anything.