search

pendulum-chain / pendulum

GNU General Public License v3.0
43 stars 14 forks source link

Implement `--version` command #456

Closed TorstenStueber closed 1 month ago

TorstenStueber commented 7 months ago

Ensure that the node clients return the version number, see this message from a third party collator:

is it possible to have versioning on collators binaries? so when we use ./amplitude-collator --version we get the correct node version and also it will be displayed on telemetry correctly, so you can check for every provider which version is running

TorstenStueber commented 7 months ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t

ebma commented 7 months ago

This ticket also entails updating our version numbers in all Cargo.toml files, doesn't it? Is this something we should talk about @TorstenStueber? Like, when do we want to bump to new major, minor, or patch versions? Or do we want to keep this number aligned to something else?

TorstenStueber commented 7 months ago

Mmhh, I did not think about this. Just thought that the version number could just be the version of the runtime. But that would not really be correct...

Then it probably makes sense to track the version of the client in the Cargo.toml of the client. We would then need to define a scheme for version numbers.

gianfra-t commented 7 months ago

I think the current node-template already has this --version flag. Not sure what it returns, but it is likely that the person was referring to this. If this is the case we should modify the client to return the same to be consistent with later versions.

TorstenStueber commented 7 months ago

Yes, that would make sense.

ebma commented 7 months ago

As far as I know, our node binaries also already support the --version flag but it's currently quite useless as we don't update the version in the Cargo.toml files which is probably the main concern of the external operators.

TorstenStueber commented 7 months ago

Okay, so the right solution would just be to add the workflow that for every client release we actively bump the version and nothing else would need to be done here ....