search

pendulum-chain / pendulum

GNU General Public License v3.0
43 stars 14 forks source link

Change chain extensions to return transferable balance #483

Closed prayagd closed 1 month ago

prayagd commented 5 months ago

Context

Related to this ticket. Fixes to be made so that Nabla modals should show up as transferrable balance.

Our chain extension exposes functions conforming to the ERC-20 interface. In ERC-20, the only function to get the balance of an address is using the balanceOf() call. At the moment, we are returning the 'free' balance of a user, see here. However, the free_balance is not necessarily the transferable balance, as it does not take into account the locked or reserved tokens.

See the relation of the system::account() query to the transferable amount.

image image

TODO

Change the balance_of function of the chain extension to return the transferable amount ie. free - reserved - frozen.

prayagd commented 5 months ago

@ebma Please fill in the details

ebma commented 5 months ago

I updated the description @prayagd.

prayagd commented 4 months ago

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

vadaynujra commented 2 months ago

Does this only apply to when the native asset (PEN) is part of Nabla @ebma ?

TorstenStueber commented 2 months ago

No, it applies to all assets.

TorstenStueber commented 2 months ago

I think it is actually good to implement this soon, now that Nabla will be live on Pendulum.