Implement the Logic for trustless Issue Requests in Spacewalk Portal

pendulum-chain / portal

The Pendulum/Amplitude portal UI

GNU General Public License v3.0

1 stars 1 forks source link

Implement the Logic for trustless Issue Requests in Spacewalk Portal #437

Open annatekl opened 5 months ago

annatekl commented 5 months ago

Context

The current setup requires users to trust vaults to execute issue requests on their behalf, which poses a security and trust concern. To address this, there's a need to add more complex logic to the portal to enable users to control issue requests directly.

Requirements

[ ] Upon receiving confirmation from the user that they have made the payment, initiate the process to call the executeIssue() extrinsic for the respective issue request.
[ ] Implement the executeIssue() extrinsic to trigger execution upon user confirmation under pending requests on the transfer page.

annatekl commented 5 months ago

Please add your planning poker estimate with Zenhub @ebma

annatekl commented 5 months ago

Hey team! Please add your planning poker estimate with Zenhub @Sharqiewicz @ebma

ebma commented 5 months ago

For this ticket, I'd like to skip writing down the technical details and just assign it to myself. The implementation will be quite involved and it would be difficult to write it all down, especially because there are some unknowns that only become obvious during the implementation. So I'd prefer working on this myself.

annatekl commented 4 months ago

Hi @ebma, it appears that implementing this change would introduce an extra step for the user. On hold for now.

ebma commented 4 months ago

it appears that implementing this change would introduce an extra step for the user.

What do you mean exactly? Can you please elaborate on which extra step you are talking about? Let's discuss

annatekl commented 4 months ago

After completing the payment via the wallet, the user needs to click on 'I have made the payment' to confirm. Even if the user doesn't confirm, the transaction will still be processed after the payment is made. This additional step is that the transaction will always need to be acknowledged by the user. @ebma

ebma commented 4 months ago

But this extra step is optional and just an additional failsafe mechanism for the user. If the user doesn't click on 'I have made the payment' after submitting the payment, then the vault would usually still perform the issuing on behalf of the user. But if the vault doesn't, the user can still act upon this themselves and execute it with the portal. Isn't that just better in any way?

ebma commented 3 months ago

@pendulum-chain/product Can I get an answer as to why this is iceboxed please? :(

vadaynujra commented 3 months ago

But if the vault doesn't, the user can still act upon this themselves and execute it with the portal. Isn't that just better in any way?

In which case would the vault not do it automatically? In that case, how do we know if the user's action will work? The feature itself isn't something that has a strong value for the user, or at least there isn't an indication in that direction. It also doesn't align to the Vortex side so just not a high priority at the moment @ebma

ebma commented 3 months ago

Okay. This is irrelevant as long as we only run vaults internally. As soon as we have or want to have external vault operators, we need to move this out of the icebox again. For our internal vaults we know that they will automatically execute the issue requests, for external vaults we cannot guarantee this as they can modify their clients or just disable it with a flag.