search

pendulum-chain / portal

The Pendulum/Amplitude portal UI
GNU General Public License v3.0
1 stars 1 forks source link

implement qr code in spacewalk bridge #442

Closed Sharqiewicz closed 1 month ago

Sharqiewicz commented 1 month ago

What:

Implement QR Code and Button compatible with Stellar SEP-0007 in order to allow user easily create transactions needed in Spacewalk.

How:

Add package: qrcode.react - the most popular package for generating qr codes in React space Create function: generateQRCodeAddress to easily create SEP-0007 URI scheme messages Divide huge TransferDialog component into smaller ones Implement SEP-0007 in ConfirmationDialog for Spacewalk > Issue and Redeem

Comments:

Tested with wallets:

Closes: #395

netlify[bot] commented 1 month ago

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
Latest commit 679f82b14c983928950d97192b6dc8cec54f74b7
Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/664dd3500fb69200091d68c5
Deploy Preview https://deploy-preview-442--rococo-souffle-a625f5.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ebma commented 1 month ago

yarn.lock changes

Click to toggle table visibility
| Name | Status | Previous | Current | | :- | :-: | :-: | :-: | | `qrcode.react` | [ADDED](#) | - | 3.1.0 |
ebma commented 1 month ago

yarn.lock changes

Click to toggle table visibility
| Name | Status | Previous | Current | | :- | :-: | :-: | :-: | | `qrcode.react` | [ADDED](#) | - | 3.1.0 |
prayagd commented 1 month ago

Agree to the solution and we should remove the button, here is the follow up ticket #448. Also please add the helper text as suggested by @ebma

ebma commented 1 month ago

yarn.lock changes

Click to toggle table visibility
| Name | Status | Previous | Current | | :- | :-: | :-: | :-: | | `qrcode.react` | [ADDED](#) | - | 3.1.0 |
ebma commented 1 month ago

yarn.lock changes

Click to toggle table visibility
| Name | Status | Previous | Current | | :- | :-: | :-: | :-: | | `qrcode.react` | [ADDED](#) | - | 3.1.0 |
ebma commented 1 month ago

yarn.lock changes

Click to toggle table visibility
| Name | Status | Previous | Current | | :- | :-: | :-: | :-: | | `qrcode.react` | [ADDED](#) | - | 3.1.0 |
prayagd commented 1 month ago

@Sharqiewicz is this done, can we merge?

ebma commented 1 month ago

yarn.lock changes

Click to toggle table visibility
| Name | Status | Previous | Current | | :- | :-: | :-: | :-: | | `qrcode.react` | [ADDED](#) | - | 3.1.0 |