search

pendulum-chain / portal

The Pendulum/Amplitude portal UI
GNU General Public License v3.0
1 stars 1 forks source link

Update error message for insufficient security deposit #443

Closed Sharqiewicz closed 1 month ago

Sharqiewicz commented 1 month ago

What:

Change Spacewalk security deposit error Change Spacewalk tokenSymbol

Closes: #417

netlify[bot] commented 1 month ago

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
Latest commit d4328942ba7d415bc7f83d8d73710c87acb88cd2
Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/664dd661d6a759000806843d
Deploy Preview https://deploy-preview-443--rococo-souffle-a625f5.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sharqiewicz commented 1 month ago

The error message looks good but I noticed that for this particular error, the 'Bridge' button does not show as disabled while for any other error regarding the schema, it disables. Any ideas @Sharqiewicz?

image

✅ Very good catch @ebma The button was implemented with disabled={!!formState.errors.amount} and it is not covering all of the errors that can appear in the form. I changed it to disabled={!isEmpty(formState.errors} and also implemented to trigger validation for every onBlur event.