Closed Sharqiewicz closed 4 months ago
Name | Link |
---|---|
Latest commit | e22bc453fd2419f29046683d363839c230360e00 |
Latest deploy log | https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/66599780b28a4800089f78a6 |
Deploy Preview | https://deploy-preview-456--rococo-souffle-a625f5.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
yarn.lock
changesStatus | Count |
---|---|
1 | |
119 |
The InputField
component has been renamed to NumericInput
for better clarity. The NumericInput
component now includes a maxDecimals
property to specify the maximum number of decimal places allowed. By default, this is set to USER_INPUT_MAX_DECIMALS.PENDULUM
.
We have defined an enum
, USER_INPUT_MAX_DECIMALS
, that includes all possible values for maxDecimals. Since we require a maximum of 7 decimal places for Stellar-related NumericInput components, we have also included USER_INPUT_MAX_DECIMALS.STELLAR
.
@Sharqiewicz as soon i open the deploy preview this error is shown, even before interacting with the input field. Can we remove that error or is it intended?
Otherwise works are expected with 7 decimals
yarn.lock
changesStatus | Count |
---|---|
1 | |
37 |
yarn.lock
changesStatus | Count |
---|---|
1 | |
37 |
yarn.lock
changesStatus | Count |
---|---|
1 | |
37 |
yarn.lock
changesStatus | Count |
---|---|
1 | |
37 |
Also looks good to me 👍 can confirm that the staking page is not broken anymore.
Just one more thing, can we change the input field of the staking dialogs to use the new one you created and then limit the amounts to 12 decimals? I noticed that they still allow an unlimited number of decimals.
Very good catch @ebma ✅
I see that in Nabla we use a separate component called NumberInput
, I think we should replace it with NumericInput
to be consistent throughout the app, but I think we can separate this to another issue.
yarn.lock
changesStatus | Count |
---|---|
1 | |
37 |
Ready for merge.
What:
When the amount for the bridge to Pendulum contains higher amount of decimals than 12, the UI remains no responsive. The inspect on the number gives an error attached in the screenshot below.
How:
Convert the input to proper extrinsic parameter type
Closes: #446