search

pendulum-chain / portal

The Pendulum/Amplitude portal UI
GNU General Public License v3.0
1 stars 1 forks source link

Show BSP and swap balance 0 when wallet not connected #469

Closed prayagd closed 4 weeks ago

prayagd commented 1 month ago

Describe the bug

Currently when the wallet is not connected to the portal, the swap UI and the BSP UI loads continuously showing a animation

Reproduction

Steps to reproduce the behavior:

  1. Go to https://portal.pendulumchain.org/foucoco/nabla/backstop-pools
  2. See the loading animation
  3. Same applies for the swap UI, the balances component also keeps loading

Expected behavior

Nothing should be displayed as the wallet is not connected to the Portal UI

Screenshots

Screenshot 2024-05-28 at 4 02 49 PM Screenshot 2024-05-28 at 4 03 01 PM

Desktop (please complete the following information):

TorstenStueber commented 1 month ago

This is not necessarily a bug in my opinion. If there is no wallet connected, I think also 0 is just wrong and could be potentially confusing – at least for me. There is just no meaningful number.

I agree that showing a loading animation does not make a lot of sense either and is unintuitive.

I would show some UI instead that indicates to "connect a wallet".

TorstenStueber commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz

prayagd commented 1 month ago

@TorstenStueber based on your response, i checked the uniswap UI. They prefer to show nothing, i think so that too works instead of the constant loading block