Open Sharqiewicz opened 1 week ago
Name | Link |
---|---|
Latest commit | b2174b06a87e432ca3ebcff150f23c8714bf62b2 |
Latest deploy log | https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/667c476d17bae900083eece9 |
Deploy Preview | https://deploy-preview-506--rococo-souffle-a625f5.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I noticed another bug:
1.1234567
.
, even if the number already has 7 decimals.@ebma Excellent catch, I am working on it ✅
@vadaynujra can you please test once done?
@ebma I refactored the whole implementation of NumericInput
events handling.
Please take a look and let me know if everything is right.
I was testing again on the same deployment link @Sharqiewicz and while manual input is correct the error with the cursor jumping to the last digit is still there and additionally when clicking on max there is the infinit number as in the attachement
@annatekl The photo isn't loading. The cursor jumps to the end of the number only if the number already has a maximum decimal and the user overwrites a new number in decimal part (without using backspace first) - otherwise the cursor doesn't jump around. What is the expected behaviour here?
Now it works like this: (max decimals is 7) ( | is the cursor )
As the user tries to exceed the maximum number of decimal places, the decimal part of the number (starting from the changed second position) is moved by one. Therefore, the cursor has moved to the end, because the entire decimal part is changed
If user uses the backspace case:
Based on the explanation, I could imagine this to be the expected behavior. @ebma do you expect the cursor to stay at the same place also in the first case?
I think the input field works great now. @annatekl shared a screenshot where the input was filled with
2.5164e-8
after clicking the MAX button. I can't reproduce because I don't have an account with that balance.
@Sharqiewicz can we maybe have a test that simulates the behaviour of MAX when a user has a balance of 0.000000025164
(decimal) ie. a raw balance of 25,164
units?
What:
Context When choosing 'Back to Stellar' and entering 'Max,' the amount prefilled by the system is half the available funds and correct, but the error message after the transaction is signed indicates that the amount is incompatible.
How:
✅ Implement maxDecimal to be also applied for StandardFrom AvailableActions