Open prayagd opened 3 weeks ago
Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz @TorstenStueber
The indexer currently only exposes a general apr
field. If we want to split this into 24h
and 7d
, we'd need to touch the indexer first.
@prayagd What is the definition of a 24 hour and a 7 day APR? It's an oxymoron, isn't it as APR is an annual rate?
Anyway, whatever that means. We calculate the APR extrapolated from the gains within the last seven days.
We calculate the APR extrapolated from the gains within the last seven days.
What we are extrapolating using APR for 7 days we want to do the same for 24h
What we are extrapolating using APR for 7 days we want to do the same for 24h
Even for doing this we need to make changes to the indexer?
Well the apr field is currently exposed by the indexer. And the nabla team also gets it from their indexer, so I think it makes most sense to do this. I found the relevant lines of code that describe the calculation they do for the 24h and 7d apr here. So IMO we should add similar changes to our indexer and then access those fields in the portal. Thus we'd need one extra ticket in pendulum-squids.
Okay, understood. But is this high priority for us? I would consider it more a nice to have – we don't need to copy every aspects of the Nabla UI at this stage of the project.
Okay, understood. But is this high priority for us?
Not a high priority, good to have in the backlog
@pendulum-chain/product as I pointed out, this ticket requires changes to the indexer before it can be worked on. I created the ticket https://github.com/pendulum-chain/pendulum-squids/issues/74 for you, please prioritize it accordingly.
Context
Currently there is only 7d APR shown on the swap pools screen, this ticket is to show both 24h and 7d APR
Todo
Note